Track occupation of patient #7152
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for care-net failed.
|
|
can you please review it |
| field.onChange({ | ||
| name: "occupation", | ||
| value: res.data.meta_info?.occupation | ||
| ? res.data.meta_info.occupation | ||
| : state.form.occupation, | ||
| }); |
There was a problem hiding this comment.
The null check can be simplified
| field.onChange({ | |
| name: "occupation", | |
| value: res.data.meta_info?.occupation | |
| ? res.data.meta_info.occupation | |
| : state.form.occupation, | |
| }); | |
| field.onChange({ | |
| name: "occupation", | |
| value: res.data.meta_info?.occupation ?? state.form.occupation, | |
| }); |
| meta_info: formData.occupation | ||
| ? { | ||
| occupation: formData.occupation, | ||
| } | ||
| : null, |
There was a problem hiding this comment.
what if there are other attributes stored in the meta_info object in the initial value? Those would get discarded right?
There was a problem hiding this comment.
{ ...initial, updated_attr: updated_val }
konavivekramakrishna
changed the title
|
can you please look into it #7152 (comment) |
|
@konavivekramakrishna if we are taking an input from the user from a form, we should be displaying it too right? let's keep it in the patient home as you've suggested in the previous comment. |
|
show other or not selected itself 😅 am I missing some context? |
|
Show "OTHER" or if not selected, "Occupation: " (blank) Lets not hide it |
|
could you please review and change the label |
|
@konavivekramakrishna modify the cypress test "Create a new patient with all fields in the registration form and no consultation" in the patient_registration.cy.ts file, to include :
|
nihal467
added
changes required
Cypress Test Pending
|
@konavivekramakrishna is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
|
could you please review |
rithviknishad
added
needs testing
and removed
changes required
Cypress Test Pending
|
LGTM |
nihal467
added
tested
reviewed
|
@konavivekramakrishna Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
Fixes Occupation of patient to be tracked #6945
backend pr Track Occupation of Patient care#1901
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist